Lo L1C - Automatic Goodtimes#2896
Open
sdhoyt wants to merge 8 commits intoIMAP-Science-Operations-Center:devfrom
Open
Lo L1C - Automatic Goodtimes#2896sdhoyt wants to merge 8 commits intoIMAP-Science-Operations-Center:devfrom
sdhoyt wants to merge 8 commits intoIMAP-Science-Operations-Center:devfrom
Conversation
…C compatible CDF production code.
sdhoyt
added
Ins: Lo
ahotasu
reviewed
Mar 31, 2026
ahotasu
approved these changes
Mar 31, 2026
Collaborator
ahotasu
left a comment
ahotasu
left a comment
There was a problem hiding this comment.
Looks good to me--all of my comments are for long-term polish and aren't needed prior to merge.
subagonsouth
reviewed
Apr 1, 2026
Contributor
subagonsouth
left a comment
subagonsouth
left a comment
There was a problem hiding this comment.
A few suggestions for improvements. Looks good other than these minor things.
Contributor
|
@sdhoyt looks like you had reviewed from both David and Tim. Please let me know if you need review from me. |
…cies for the entire pointing, consistent with the current Ancillary file. Also added logic to handle creation of output files with 0 start and end times when no GoodTimes are detected. Added test case to cover no goodtimes detected and updated other test cases as needed per the other change. Validated output against current ancillary files using flight data for 2026-02-21 through 02-28.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This code integrates Lo's python code for automatic goodtimes into the processing code.
I'm running into a mypy issue because of the number of if statements in a function. I'd like to push fixing that to another ticket a little later down the road to prioritize the remaining work I have for the 3 month maps.
I compared goodtimes values to the results of Lo's script. There was divergence, up to a few hundred seconds. If this needs to be more accurate, I'd also propose pushing this to a later change.
Closes #2841